Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Use DisplayMetrics instead of WindowManager for StrictMode Error #483

Merged
merged 1 commit into from
May 29, 2024
Merged

fix: Use DisplayMetrics instead of WindowManager for StrictMode Error #483

merged 1 commit into from
May 29, 2024

Conversation

Mansi-mParticle
Copy link
Contributor

Instructions

  1. PR target branch should be against development
  2. PR title name should follow this format: https:/mParticle/mparticle-workflows/blob/main/.github/workflows/pr-title-check.yml
  3. PR branch prefix should follow this format: https:/mParticle/mparticle-workflows/blob/main/.github/workflows/pr-branch-check-name.yml

Summary

-Resolved StrictMode error by replacing direct usage of application context's WindowManager with DisplayMetrics.

Testing Plan

  • Was this tested locally? If not, explain why.
  • Tested locally

Reference Issue (For mParticle employees only. Ignore if you are an outside contributor)

@rmi22186 rmi22186 force-pushed the development branch 4 times, most recently from fca8a44 to b67c108 Compare May 29, 2024 19:20
@einsteinx2 einsteinx2 merged commit 648c079 into development May 29, 2024
23 of 24 checks passed
@einsteinx2 einsteinx2 deleted the SQDSDKS-6262-StrictMode-Error branch May 29, 2024 22:01
mparticle-automation added a commit that referenced this pull request May 31, 2024
@mparticle-automation
chore: 5.55.8 (release)
f817158 
## [5.55.8](v5.55.7...v5.55.8) (2024-05-31)

### Bug Fixes

* Use DisplayMetrics instead of WindowManager for StrictMode Error ([#483](#483)) ([648c079](648c079))

### Updates & Maintenance

* Update submodules ([fa40e06](fa40e06))
@mparticle-automation
Copy link
Collaborator

🎉 This PR is included in version 5.55.8 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Mansi-mParticle added a commit that referenced this pull request Jun 6, 2024
@Mansi-mParticle
fix: Use DisplayMetrics instead of WindowManager for StrictMode Error (…
cbe6813 
…#483)
Mansi-mParticle pushed a commit that referenced this pull request Jun 6, 2024
@mparticle-automation @Mansi-mParticle
chore: 5.55.8 (release)
bb84a45 
## [5.55.8](v5.55.7...v5.55.8) (2024-05-31)

### Bug Fixes

* Use DisplayMetrics instead of WindowManager for StrictMode Error ([#483](#483)) ([648c079](648c079))

### Updates & Maintenance

* Update submodules ([fa40e06](fa40e06))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samdozor samdozor samdozor approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Mansi-mParticle @mparticle-automation @samdozor @einsteinx2