Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add option to disable certificate pinning #495

Merged
merged 1 commit into from
Jun 25, 2024
Merged

feat: Add option to disable certificate pinning #495

merged 1 commit into from
Jun 25, 2024

Conversation

Mansi-mParticle
Copy link
Contributor

Instructions

  1. PR target branch should be against development
  2. PR title name should follow this format: https:/mParticle/mparticle-workflows/blob/main/.github/workflows/pr-title-check.yml
  3. PR branch prefix should follow this format: https:/mParticle/mparticle-workflows/blob/main/.github/workflows/pr-branch-check-name.yml

Summary

  • Added an option to disable certificate pinning, even in production.

Testing Plan

  • Was this tested locally? If not, explain why.
  • Tested with sample application
  • Bad certificate and pinning option is false ( no response from the api)

Screenshot 2024-06-25 at 5 30 58 PM

  • Bad certificate and pinning option is true

Screenshot 2024-06-25 at 5 33 37 PM

Screenshot 2024-06-25 at 5 34 55 PM

Reference Issue (For mParticle employees only. Ignore if you are an outside contributor)

@Mansi-mParticle Mansi-mParticle changed the base branch from main to development June 25, 2024 21:46
einsteinx2
einsteinx2 approved these changes Jun 25, 2024
View reviewed changes
Copy link
Collaborator

@einsteinx2 einsteinx2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for the detailed verification support!

@einsteinx2 einsteinx2 merged commit 7c53bad into development Jun 25, 2024
22 of 24 checks passed
@einsteinx2 einsteinx2 deleted the feat/SQDSDKS-6541--Add-Option-To-Disable-Cert-Pinning branch June 25, 2024 22:07
mparticle-automation added a commit that referenced this pull request Jun 25, 2024
@mparticle-automation
chore: 5.56.0 (release)
e784d81 
## [5.56.0](v5.55.9...v5.56.0) (2024-06-25)

### Features

* Add option to disable certificate pinning ([#495](#495)) ([7c53bad](7c53bad))
@mparticle-automation
Copy link
Collaborator

🎉 This PR is included in version 5.56.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@einsteinx2 einsteinx2 einsteinx2 approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Mansi-mParticle @mparticle-automation @einsteinx2