fix: add etag to batch upload payload #114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mchuangatmp
force-pushed
the
fix/81946-etag
branch
from
098b4c1
to
b58fc16
Compare
einsteinx2
approved these changes
Mar 9, 2022
There was a problem hiding this comment.
LGTM. Afaik the keys are arbitrary and in fact these "short keys" are then converted to "long keys" on the backend (something we would implement later for this key when we add support for parsing/storing it), and are only used as a way to decrease network data usage, making them especially arbitrary since they're not even the final keys used in the system.
mchuangatmp
force-pushed
the
fix/81946-etag
branch
from
b58fc16
to
2367653
Compare
|
Kudos, SonarCloud Quality Gate passed! |
willpassidomo
approved these changes
Mar 9, 2022
github-actions bot
pushed a commit
that referenced
this pull request
Mar 9, 2022
## [5.36.2](v5.36.1...v5.36.2) (2022-03-09) ### Bug Fixes * add etag to batch upload payload ([#114](#114)) ([6ce43aa](6ce43aa))
|
🎉 This PR is included in version 5.36.2 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instructions
Summary
Testing Plan
Master Issue