ci: improve instrumented test consistency #117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willpassidomo
changed the title
willpassidomo
force-pushed
the
ci/SQDSDKS-3571-fix-flakiness
branch
from
6afe226
to
71c566c
Compare
mchuangatmp
approved these changes
Mar 21, 2022
|
Kudos, SonarCloud Quality Gate passed!
|
|
🎉 This PR is included in version 5.37.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
testModifyMessage() is one of our flakier tests and I found this is in part due to some asynchronous writed to
SharedPreferences. In this test, we are making multiple updates to the same mpid/user, which is not required for the test case. This update simply changes the user each iteration so we do not need to account for the async updatesTesting Plan
existing tests pass
Master Issue