fix: Proguard keeps KitsLoadedCallback #119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willpassidomo
force-pushed
the
fix/SQDSDKS-3593-proguard-kitsloadedcallback
branch
from
2b28dd5
to
ef407dc
Compare
willpassidomo
force-pushed
the
fix/SQDSDKS-3593-proguard-kitsloadedcallback
branch
from
ef407dc
to
87683b7
Compare
|
Kudos, SonarCloud Quality Gate passed! |
mchuangatmp
approved these changes
Mar 24, 2022
mchuangatmp
reviewed
Mar 24, 2022
| run: ./gradlew -PisRelease=true clean testRelease publishReleaseLocal -c settings-kits.gradle | ||
| run: | | ||
| ./gradlew -PisRelease=true clean publishReleaseLocal -c settings-kits.gradle | ||
| ./gradlew -p kits testRelease |
There was a problem hiding this comment.
can we add this to daily.yml too?
|
🎉 This PR is included in version 5.37.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Our last release failed because I missed a progaurd update in our last change which broke kits & kit-base in release builds.
This PR:
BackgroundTaskHandlerthat I missedTesting Plan
added additional tests to make sure these kinds of bugs are caught during PR
Master Issue