fix: modify() call throws an exception when user is not present #195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willpassidomo
force-pushed
the
fix/SQDSDKS-4270-modify-exception
branch
from
8515edd
to
bb8b552
Compare
mchuangatmp
approved these changes
Jul 1, 2022
When the AdId updates, we will generate a modify() request interanlly with the current user. When the current user is not present/null, this request currently fails with an error log or a thrown exception, if the SDK is running in Development mode. In order to avoid losing this modify request or causing an exception, we will defer the modify request until a user is present, if it is not already
willpassidomo
force-pushed
the
fix/SQDSDKS-4270-modify-exception
branch
from
bb8b552
to
e3e3c98
Compare
github-actions bot
pushed a commit
that referenced
this pull request
Jul 1, 2022
## [5.41.3](v5.41.2...v5.41.3) (2022-07-01) ### Bug Fixes * config migration logic causes kits to deinit on re-upgrade ([#196](#196)) ([ae210c4](ae210c4)) * modify() call throws an exception when user is not present ([#195](#195)) ([72731d5](72731d5)) ### Updates & Maintenance * Update Submodules ([99fed27](99fed27))
|
🎉 This PR is included in version 5.41.3 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When the AdId updates, we will generate a modify() request interanlly with the current user. When the current user is not present/null, this request currently fails with an error log or a thrown exception, if the SDK is running in Development mode. In order to avoid losing this modify request or causing an exception, we will defer the modify request until a user is present, if it is not already
Testing Plan
Master Issue