Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: bump up compile SDK and ktlint version #245

Merged
merged 1 commit into from
Oct 3, 2022
Merged

feat: bump up compile SDK and ktlint version #245

merged 1 commit into from
Oct 3, 2022

Conversation

mchuangatmp
Copy link
Contributor

Instructions

  1. PR target branch should be against development
  2. PR title name should follow this format: https:/mParticle/mparticle-workflows/blob/stable/.github/workflows/pr-title-check.yml
  3. PR branch prefix should follow this format: https:/mParticle/mparticle-workflows/blob/stable/.github/workflows/pr-branch-check-name.yml

Summary

  • bump up compile SDK to 33
  • bump up ktlint version

Testing Plan

  • regression tests should all pass except crossplatforms (we'll need a PR to update AGP there)

Reference Issue

@sonarcloud
Copy link

sonarcloud bot commented Oct 3, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 4 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

einsteinx2
einsteinx2 approved these changes Oct 3, 2022
View reviewed changes
Copy link
Collaborator

@einsteinx2 einsteinx2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mchuangatmp mchuangatmp merged commit 67dc378 into development Oct 3, 2022
@mchuangatmp mchuangatmp deleted the feat/SQDSDKS-4523-android13 branch October 3, 2022 23:58
mparticle-automation added a commit that referenced this pull request Oct 14, 2022
@mparticle-automation
chore: 5.46.0 (release)
716146c 
## [5.46.0](v5.45.2...v5.46.0) (2022-10-14)

### Features

* Bump up compile SDK to 33 and ktlint version ([#245](#245)) ([67dc378](67dc378))
* Port android core module java instrumented and unit tests to kotlin - phase1 ([#249](#249)) ([62e4254](62e4254))
* Port android core module java instrumented and unit tests to kotlin (p2) ([#250](#250)) ([23434d2](23434d2))
* Ported Android Kit Base tests to Kotlin ([#253](#253)) ([c21dd71](c21dd71))
* update isLimitAdTracking logic for Android 13 ([#233](#233)) ([f7b9284](f7b9284))

### Bug Fixes

* Convert MParticleTest.java file to kotlin and fix failing test ([#251](#251)) ([604c1b9](604c1b9))

### Documentation

* Update copy in readme for android 13 ([#255](#255)) ([c9a648d](c9a648d))

### Updates & Maintenance

* add in missing inherit in rebase job ([2197610](2197610))
* Update submodules ([7bdaf63](7bdaf63))
* Update to kotlin 1.7.20 ([#247](#247)) ([c9e1729](c9e1729))
@mparticle-automation
Copy link
Collaborator

🎉 This PR is included in version 5.46.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@einsteinx2 einsteinx2 einsteinx2 approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mchuangatmp @mparticle-automation @einsteinx2