feat: Background Event batching based delay #450
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… batch upload Implementing as the legacy impl, a delayed message with type UPLOAD based on dynamic delay Adding feature flag ebb to "enableBackgroundBatching", read from config and default=false Adding Service for uploading Adding class in proguard Business logic changes on AppStateManager to route to different implementations based on feature flag. Business logic change at the upload handler level to dismiss automatic upload interval and upload at session end when batching is enabled.
markvdouw
force-pushed
the
feat/SQDSDKS-5924-event-batching
branch
2 times, most recently
from
1cc545c
to
e655a1f
Compare
einsteinx2
requested changes
Nov 27, 2023
android-core/src/main/java/com/mparticle/internal/ConfigManager.java
Outdated
Show resolved
Hide resolved
android-core/src/main/java/com/mparticle/internal/ConfigManager.java
Outdated
Show resolved
Hide resolved
android-core/src/main/java/com/mparticle/internal/UploadHandler.java
Outdated
Show resolved
Hide resolved
markvdouw
force-pushed
the
feat/SQDSDKS-5924-event-batching
branch
from
e655a1f
to
910b714
Compare
einsteinx2
requested changes
Nov 28, 2023
android-core/src/main/kotlin/com.mparticle/JobSchedulerUtils.kt
Outdated
Show resolved
Hide resolved
markvdouw
force-pushed
the
feat/SQDSDKS-5924-event-batching
branch
from
910b714
to
99ae712
Compare
samdozor
requested changes
Dec 1, 2023
| SchedulingBatchingType.PERIODIC, | ||
| true, | ||
| delay -> { | ||
| sendEmptyDelayed(UPLOAD_MESSAGES, uploadInterval); |
There was a problem hiding this comment.
there's something funky here. I tested by setting the upload interval to 30 seconds and set the SDK to production mode. When using the legacy upload mode - i'm not seeing uploads every 30s - it seems to be much quicker.
| context.scheduleJob(builder.build()) | ||
| } catch (e: Exception) { | ||
| Logger.error("Error while trying to use JobSceduler for batch upload") | ||
| legacyAction.invoke(delayInSeconds.secondsToMillis()) |
There was a problem hiding this comment.
delayInSeconds is already in milliseconds when it's passed in....
| } | ||
| context.scheduleJob(builder.build()) | ||
| } catch (e: Exception) { | ||
| Logger.error("Error while trying to use JobSceduler for batch upload") |
There was a problem hiding this comment.
When using this I get spammed with error messages saying "Error while trying to use JobSceduler for batch upload" (including the typo..).
Can we check programmatically if the service is there rather than relying on an exception?
And - rather than a vague error, we should log more or a warning that includes the code that they need to add to their manifest, and let them know that as a result of this, we may not be able to upload in the background.
Deprecating function in Media API Minor business logic changes in AppStatemanager Removing featrue flag on ConfigManager for platform consistency
markvdouw
force-pushed
the
feat/SQDSDKS-5924-event-batching
branch
from
99ae712
to
d973342
Compare
sdk is backgrounded and there are no messages stored pending and the upload table is empty.
einsteinx2
force-pushed
the
development
branch
from
a533731
to
32c788e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background Event batching based delay
Instructions
developmentSummary
Testing Plan
Please consider that the JobScheduler specifies that the job will be triggered at MOST one time within the interval but there is no guarantee when the job will be trigger, meaning the delay can be very inexact and this could be a challange while testing.
Images are attached:
Reference Issue (For mParticle employees only. Ignore if you are an outside contributor)