fix:accept CurrentPlayheadPosition with 0 value

mParticle · Sep 5, 2024 · 80550ac · 80550ac
1 parent 18a8801
commit 80550ac
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 2 deletions.
diff --git a/src/session.ts b/src/session.ts
@@ -160,8 +160,7 @@ export class MediaSession {
  options: Options = {},
  ): MediaEvent {
  // Set event option based on options or current state
- this.currentPlayheadPosition =
- options?.currentPlayheadPosition || this.currentPlayheadPosition;
+ this.currentPlayheadPosition = options?.currentPlayheadPosition;
 
  // Merge Session Attributes with any other optional Event Attributes.
  // Event-Level Custom Attributes will override Session Custom Attributes if there is a collison.

diff --git a/test/session.test.ts b/test/session.test.ts
@@ -746,6 +746,24 @@ describe('MediaSession', () => {
  );
  expect(bond.args[0][0].options.currentPlayheadPosition).to.eq(32);
  });
+
+ it('accepts currentPlayheadPosition with a value of 0', () => {
+ const bond = sinon.spy(mp, 'logBaseEvent');
+
+ const options = {
+ currentPlayheadPosition: 0,
+ customAttributes: {
+ content_rating: 'epic',
+ },
+ };
+
+ mpMedia.logMediaSessionStart(options);
+
+ expect(bond.args[0][0].options.customAttributes).to.eqls(
+ options.customAttributes,
+ );
+ expect(bond.args[0][0].options.currentPlayheadPosition).to.eq(0);
+ });
  });
 
  describe('#logMediaSessionEnd', () => {