Update to latest version of sir-trevor-js master branch and fix bindFormSubmit #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I just saw problems when adding new types of content, i will make views in ruby for that and update this pull request. |
|
Finished new blocks, can be merged. |
|
Is there any reason why this pull-request is dead? It would be great to have the latest version of Sir-Trevor in here. |
|
I haven't worked on it because we don't use it anymore. Also i never got a reaction to this PR unfortunately. I did really like the code and wouldn't mind keeping this up if there's a need for that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add new javascript and css
Also made a fix SirTrevor.bindFormSubmit 2e4125f
The formbound variable is set to the SirTrevor object. This means when you have multiple instances the formBound attribute will be set as true on the first time and won't bind onFormSubmit to the other forms. This broke our application and therefor we made this fix. Maybe this is not the best solution, but it works for us. A formBound on the Editor instance would maybe work?