Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow nikic/php-parser ^5.0.0 #545

Open
wants to merge 11 commits into
base: 4.12.x
Choose a base branch
from

Conversation

gazben
Copy link

@gazben gazben commented Jul 14, 2024

The nikic/php-parser package is now upgraded to 5.0. According to the changelog, this version drops the php 5 parsing and requires php 7.4.

There is automated MR regarding this topic: #484

But that MR takes a more radical approach by not allowing the v4 version.

Changelog: https:/nikic/PHP-Parser/releases/tag/v5.0.0

@Ocramius
Copy link
Collaborator

This patch can only be merged if CI also runs the newest dependencies: "allowing" them is insufficient, and #484 highlights the associated failures

@gazben
Copy link
Author

gazben commented Jul 14, 2024

Okay, in this case I'll update the MR in the next release of vimeo/psalm is released: https:/vimeo/psalm/blob/master/composer.json#L36

renovate bot added 11 commits September 3, 2024 13:20
| datasource | package         | from    | to      |
| ---------- | --------------- | ------- | ------- |
| packagist  | phpunit/phpunit | 10.5.30 | 10.5.31 |
| datasource | package         | from   | to     |
| ---------- | --------------- | ------ | ------ |
| packagist  | phpstan/phpstan | 1.12.0 | 1.12.1 |
| datasource | package         | from    | to      |
| ---------- | --------------- | ------- | ------- |
| packagist  | phpunit/phpunit | 10.5.31 | 10.5.32 |
| datasource | package         | from   | to     |
| ---------- | --------------- | ------ | ------ |
| packagist  | phpstan/phpstan | 1.12.1 | 1.12.2 |
| datasource | package     | from   | to     |
| ---------- | ----------- | ------ | ------ |
| packagist  | vimeo/psalm | 5.25.0 | 5.26.0 |
| datasource | package         | from    | to      |
| ---------- | --------------- | ------- | ------- |
| packagist  | phpstan/phpstan | 1.12.2  | 1.12.3  |
| packagist  | phpunit/phpunit | 10.5.32 | 10.5.33 |
| datasource | package     | from   | to     |
| ---------- | ----------- | ------ | ------ |
| packagist  | vimeo/psalm | 5.26.0 | 5.26.1 |
| datasource | package         | from    | to      |
| ---------- | --------------- | ------- | ------- |
| packagist  | phpunit/phpunit | 10.5.33 | 10.5.34 |
@Ocramius
Copy link
Collaborator

Diff no longer contains "nikic/php-parser": "^5",?

@gazben
Copy link
Author

gazben commented Sep 14, 2024

I thought that with the new release of vimeo/psalm the dependency is upgraded and I rebased the branch, but I learned quickly that this is not the case. I'm waiting for this vimeo/psalm#11035

Sorry for the confusion

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants