Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Helper Data's function being used with "$this" into Migration Helper #1196

Closed
giorello opened this issue Nov 25, 2020 · 0 comments · Fixed by #1200
Closed

Helper Data's function being used with "$this" into Migration Helper #1196

giorello opened this issue Nov 25, 2020 · 0 comments · Fixed by #1200
Assignees
@giorello
Labels
bug done
Milestone
1.1.22

Comments

@giorello
Copy link
Contributor

This happens when the Data should be migrated from old versions of our extension to the latest.

Preconditions

  1. Mailchimp's extension v1.1.21
@giorello giorello added the bug label Nov 25, 2020
@giorello giorello added this to the 1.1.22 milestone Nov 25, 2020
@giorello giorello self-assigned this Nov 25, 2020
@giorello giorello mentioned this issue Dec 8, 2020
Closed
roberto-ebizmarts pushed a commit that referenced this issue Jan 6, 2021
@robertsp86
Making getMageApp() method being called by the Migration Helper.
3e457d0 
closes #1196
@roberto-ebizmarts roberto-ebizmarts mentioned this issue Jan 6, 2021
Merged
roberto-ebizmarts pushed a commit that referenced this issue Jan 14, 2021
@robertsp86
Making isEcomSyncDataEnabled() and setIsSyncingIfFinishedPerScope() m…
8b38c28 
…ethods being called by the Migration Helper.

Becoming setIsSyncingIfFinishedPerScope() in a public method.
closes #1196
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@giorello giorello

Labels
bug done
Projects
None yet
Milestone
1.1.22
Development

Successfully merging a pull request may close this issue.

Making getMageApp() method being called by the Migration Helper. mailchimp/mc-magento
2 participants
@gonzaloebiz @giorello