flesh out server-side setup instructions in README #155
Conversation
| self.resource = warden.authenticate!(auth_options) | ||
| sign_in(resource_name, resource) | ||
| yield resource if block_given? | ||
| render json: resource, status: 201 |
There was a problem hiding this comment.
Doesn't this return the full user object? Don't thank that's great as it reveals much more data than necessary - would prefer that:
data = {
auth_token: resource.authentication_token,
auth_email: resource.email
}
render json: data, status: 201There was a problem hiding this comment.
Good point. I'm using ActiveModel::Serializers, which is really the "right" way to handle what's exposed, but I think it's better to have an example that's safe by default.
|
i updated the example sessions controller based on your feedback, as well as adding a small refactor to remove some unnecessary code that's already inherited from devise. |
| def create | ||
| self.resource = warden.authenticate!(auth_options) | ||
| sign_in(resource_name, resource) | ||
| yield resource if block_given? |
There was a problem hiding this comment.
I think that's only necessary in Devise's implementation of the #create method - you'd never get a block here.
|
okay, removed that unnecessary line from the example sessions controller. let me know if you have any other feedback! |
|
I'm on vacation currently - will look at this in 2 weeks. |
|
merged: 2737025 |
* Enable HBS transforms for Ember 1.13.0 and below again * Fix HBS transforms for AST difference in Ember 1.11/1.12 * Extract Ember version checks into separate module * Reenable most positional param to hash pair tests * Remove unused `ember-compatibility-helpers` dependency
Fixes #154.