Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix deprecation warning when running with Ember 3.6 #1722

Merged
merged 1 commit into from
Dec 13, 2018
Merged

Fix deprecation warning when running with Ember 3.6 #1722

merged 1 commit into from
Dec 13, 2018

Conversation

richard-viney
Copy link
Contributor

@richard-viney richard-viney commented Dec 9, 2018 •
edited
Loading

In Ember 3.6 the off() function must be given the specific handler function to remove.

@richard-viney
Fix deprecation warnings when running with Ember 3.6
1be5087 
In Ember 3.6 the off function must be given the specific handler function to remove.
marcoow
marcoow approved these changes Dec 13, 2018
View reviewed changes
Copy link
Member

@marcoow marcoow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@marcoow marcoow merged commit 5b3a73d into mainmatter:master Dec 13, 2018
@mydea
Copy link

mydea commented Dec 20, 2018

Any plans on when a new release will be made? :)

@richard-viney
Copy link
Contributor Author

richard-viney commented Dec 20, 2018 •
edited
Loading

May have missed a deprecation here, am seeing this now: DEPRECATION: You attempted to remove a function listener which did not exist on the instance, which means it was an inherited prototype listener, or you attempted to remove it before it was added. Prototype function listeners have been deprecated, and attempting to remove a non-existent function listener this will error in the future. [deprecation id: events.inherited-function-listeners] See https://emberjs.com/deprecations/v3.x#toc_events-inherited-function-listeners for more details.

Will do another small fix for this.

@richard-viney
Copy link
Contributor Author

#1725

@richard-viney richard-viney mentioned this pull request Dec 20, 2018
Merged
mfeckie pushed a commit to mfeckie/ember-simple-auth that referenced this pull request Oct 4, 2019
@richard-viney @mfeckie
Fix deprecation warnings when running with Ember 3.6 (mainmatter#1722)
d1af81e 
In Ember 3.6 the off function must be given the specific handler function to remove.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcoow marcoow marcoow approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@richard-viney @mydea @marcoow