Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use on modifier rather in octane examples #2032

Merged
merged 1 commit into from
Nov 22, 2019
Merged

Use on modifier rather in octane examples #2032

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions guides/octane-auth-torii-with-github.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -188,7 +188,7 @@ Now let’s create our skeletal templates by editing the three files in
<p>
{{#if this.session.isAuthenticated}}
Authenticated <br>
<button onclick={{this.logout}}>Log Out</button>
<button {{on "click" this.logout}}>Log Out</button>
{{else}}
Unauthenticated
{{/if}}
Expand Down Expand Up @@ -404,7 +404,7 @@ Change the `login` template to send the `login()` action when the button is pres
```handlebars
{{!-- app/templates/login.hbs --}}
<h3>Login Route</h3>
<button onclick={{this.login}}>Log in to GitHub</button>
<button {{on "click" this.login}}>Log in to GitHub</button>
```

The “Log Out” button was already associated with the `logout()` action, but
Expand Down