Modernize dummy app #2135
Merged
Modernize dummy app #2135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Turbo87
reviewed
Mar 18, 2020
| @@ -7,14 +7,14 @@ | |||
| <form {{action 'authenticateWithOAuth2' on='submit'}}> | |||
| <div class="form-group"> | |||
| <label for="identification">Login</label> | |||
| {{input value=identification placeholder='Enter Login' class='form-control'}} | |||
| <input type="text" placeholder="Enter Login" class="form-control" onchange={{action 'updateIdentification'}} value={{this.identification}} /> | |||
There was a problem hiding this comment.
hmm, what's the reason for this change? why not keep using the <Input> component?
There was a problem hiding this comment.
I find using native inputs easier to follow and more explicit. What would be an advantage of the <Input> component?
marcoow
force-pushed
the
modernize-dummy-app
branch
from
29dc311
to
0302dba
Compare
locks
reviewed
Mar 18, 2020
marcoow
force-pushed
the
modernize-dummy-app
branch
from
0302dba
to
810baee
Compare
marcoow
force-pushed
the
modernize-dummy-app
branch
from
810baee
to
b7d45a0
Compare
Turbo87
approved these changes
Mar 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This modernizes the dummy app by:
async/awaitinstead of dealing with promisessendActioninputhelperIt also fixes handling of invalid credentials and other login errors in the
<LoginForm>which is currently broken.