Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add docs and test for sameSite attribute in AdaptiveStorage #2239

Merged
merged 1 commit into from
Jul 22, 2022

Conversation

makepanic
Copy link
Contributor

@makepanic makepanic commented Aug 27, 2020

#2312 added proxying of the attribute but did not add proper documentation and testing.

@makepanic
Copy link
Contributor Author

makepanic commented Aug 27, 2020

From the issue comment:

adding the new property to the adaptive store and documenting it

I've copied the documentation from the cookie store sameSite jsdoc comment.

passing it to the cookie store

done

adding a test for that behavior (I know the adaptive store tests are a mess – if you need help with that, let me know)

I've extended the existing cookie attribute related adaptive test.
I could also add a new test for this one case as the existing one might have a different focus.

@marcoow marcoow force-pushed the issues/2230 branch 2 times, most recently from e6094ea to 9ad0b55 Compare April 29, 2022 13:46
@marcoow marcoow changed the title fix(adaptive): ensure sameSite is proxied from internal store add docs and test for sameSite attribute in AdaptiveStorage Apr 29, 2022
@BobrImperator BobrImperator merged commit dd10ccb into mainmatter:master Jul 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants