Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add embroider tests #2484

Merged

Conversation

BobrImperator
Copy link
Collaborator

Webpack imports don't allow to override default() on a module.
Location util needed to be refactored so it proxies to window.replace and allow us to listen to the proxy method instead.

  • changes how util/location works
  • adds embroider tests

@BobrImperator BobrImperator merged commit 6874387 into mainmatter:master Nov 19, 2022
@BobrImperator BobrImperator deleted the add-embroider-safe-test branch November 19, 2022 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant