Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade torii devDependency to 1.0.0-beta.1 #2512

Merged
merged 2 commits into from
Feb 8, 2023

Conversation

Gaurav0
Copy link
Contributor

@Gaurav0 Gaurav0 commented Jan 30, 2023

Maintainer edit:

  • adds ember-lts-4.8 try scenario.
  • bumps torii to the adopted 1.0.0-beta.1 https:/adopted-ember-addons/torii
  • bumps packages in the package.jsons for the default ember scenario.

@Gaurav0
Copy link
Contributor Author

Gaurav0 commented Jan 30, 2023

@BobrImperator can you approve running the tests?

@BobrImperator
Copy link
Collaborator

Thanks 👍

My concern though is dropping the older ember support, is it necessary?
I'd also prefer to wait for official 1.0.0 release rather than installing beta if possible, this is why we haven't upped this one yet.

@Gaurav0
Copy link
Contributor Author

Gaurav0 commented Jan 30, 2023

I'd also prefer to wait for official 1.0.0 release rather than installing beta if possible, this is why we haven't upped this one yet.

Ok. I'll talk to @halfbyte about releasing a 1.0.

@Gaurav0 Gaurav0 force-pushed the upgrade_torii branch 2 times, most recently from 562657e to bb4e962 Compare January 30, 2023 16:57
@Gaurav0
Copy link
Contributor Author

Gaurav0 commented Jan 30, 2023

My concern though is dropping the older ember support, is it necessary?

Not for this, as torii is just a devdependency. Once I get tests working otherwise, I'll reenable testing on older versions and use the old version of torii in those ember-try scenarios.

@Gaurav0 Gaurav0 force-pushed the upgrade_torii branch 15 times, most recently from b4d3e6d to b8e8aba Compare January 30, 2023 19:47
@Gaurav0 Gaurav0 force-pushed the upgrade_torii branch 2 times, most recently from ffff3a2 to 5fc4e44 Compare February 4, 2023 16:47
@BobrImperator BobrImperator added the dependencies Pull requests that update a dependency file label Feb 6, 2023
@BobrImperator BobrImperator merged commit dcfd7e4 into mainmatter:master Feb 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants