Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add GetMemoryInformation request to kerncfg/posix #582

Merged
merged 2 commits into from
Jul 9, 2024
Merged

Add GetMemoryInformation request to kerncfg/posix #582

merged 2 commits into from
Jul 9, 2024

Conversation

Qwinci
Copy link
Contributor

@Qwinci Qwinci commented Oct 20, 2023

No description provided.

@Qwinci Qwinci mentioned this pull request Oct 20, 2023
Open
@avdgrinten
Copy link
Member

Getting informative data from the kernel is better done by adding a kerncfg request. That way, we don't need to add a lot of additional syscalls, and it's easier to do access control and versioning.

@Qwinci
Copy link
Contributor Author

Qwinci commented Oct 23, 2023

I moved it to kerncfg like you suggested.

@Qwinci Qwinci changed the title thor: Add helGetMemoryInformation syscall Add GetMemoryInformation request to kerncfg/posix Oct 23, 2023
qookei
qookei reviewed Oct 23, 2023
View reviewed changes
Copy link
Member

@qookei qookei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine to me, although I'm unsure if this is the right time to start using separate response messages instead of adding fields to the SvrResponse message.

no92
no92 approved these changes Oct 28, 2023
View reviewed changes
Copy link
Member

@no92 no92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Qwinci Qwinci force-pushed the meminfo branch 2 times, most recently from 1e817b7 to 513c512 Compare December 1, 2023 11:52
ElectrodeYT
ElectrodeYT approved these changes Jun 4, 2024
View reviewed changes
Copy link
Member

@ElectrodeYT ElectrodeYT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Dennisbonke
Dennisbonke approved these changes Jun 5, 2024
View reviewed changes
Copy link
Member

@Dennisbonke Dennisbonke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Dennisbonke Dennisbonke merged commit 7c848ad into managarm:master Jul 9, 2024
4 checks passed
@Qwinci Qwinci deleted the meminfo branch September 23, 2024 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qookei qookei qookei left review comments

@no92 no92 no92 approved these changes

@Dennisbonke Dennisbonke Dennisbonke approved these changes

@ElectrodeYT ElectrodeYT ElectrodeYT approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Qwinci @avdgrinten @no92 @Dennisbonke @ElectrodeYT @qookei