Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for different templates and upgrade to Angular 12 #29

Merged
merged 31 commits into from
Aug 10, 2021

Conversation

mraible
Copy link
Collaborator

@mraible mraible commented Jun 23, 2021

Fixes #23.

@mraible
Copy link
Collaborator Author

mraible commented Jun 23, 2021

npm test fails with:

    Failed: Could not find an NgModule. Use the skip-import option to skip importing in NgModule.
  Stack:
    Error: Could not find an NgModule. Use the skip-import option to skip importing in NgModule.
        at findModule (/Users/mraible/dev/angular-crud/angular-crud/node_modules/schematics-utilities/node_modules/@schematics/angular/utility/find-module.js:80:11)
        at Object.findModuleFromOptions (/Users/mraible/dev/angular-crud/angular-crud/node_modules/schematics-utilities/node_modules/@schematics/angular/utility/find-module.js:24:33)

I believe this is because schematics-utilities doesn't support Angular 12. If I change to use Angular CDK instead, it's a similar error.

@mraible
Copy link
Collaborator Author

mraible commented Jun 24, 2021

@manfredsteyer Are you OK with the changes in e417492? This makes it so the generated code more closely aligns with what I'd expect. It also represents the changes I made in Build Beautiful Angular Apps with Bootstrap.

@mraible
Copy link
Collaborator Author

mraible commented Jun 25, 2021

@manfredsteyer I decided to keep your theme as a set of templates referred to as paper-dashboard. If I'm able to add a set of templates for Angular Material, can you assist with a release in the next few days?

@mraible
Copy link
Collaborator Author

mraible commented Jun 25, 2021

It probably makes sense to create demos for each framework (bootstrap, material, and paper-dashboard). Could require a few hours of work but will likely result in higher quality.

@mraible
Copy link
Collaborator Author

mraible commented Aug 6, 2021

I added demos for Bootstrap and Angular Material. However, this is still more work to do. I need to figure out why the navbar doesn't show up in the origin demo. Once I get it working there, I'll try to get it working with the other examples.

There's also an issue with Angular Material where the height of the page is not dynamically calculated and the form's width is not calculated.

Update: I posted a question to Stack Overflow asking how to fix the dynamic height issue.

@mraible
Copy link
Collaborator Author

mraible commented Aug 8, 2021

@manfredsteyer I updated the original demo to use Bootstrap 5 and fixed the navbar issue. I don't think the other demos really need the navbar, so I didn't include it. I'll QA this tomorrow (Monday) and it should be ready for a release shortly after.

@mraible mraible merged commit a20ce4a into master Aug 10, 2021
@mraible mraible deleted the styles-support branch August 10, 2021 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for Angular Material in templates
1 participant