Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add OData cast to OData query. #176

Open
mathiaac opened this issue Sep 14, 2022 · 4 comments
Open

add OData cast to OData query. #176

mathiaac opened this issue Sep 14, 2022 · 4 comments
Labels
enhancement New feature or request

Comments

@mathiaac
Copy link

Would it be possible (or is there already a way to do it?) to add casting as part of constructing the OData query, as per example 3 and 4 from the official docs? https://docs.microsoft.com/en-us/graph/api/group-list-members?view=graph-rest-1.0&tabs=http

Because if I now for instance want to list all users that are members of a group I have to list all members, iterate through them and calling get on the user client and then I will of course get a bunch of 404 errs which I have to handle. Whereas if I could cast ListMembers to users then I would be set with that one call. Think this would also solve this issue. #20

Thanks for the SDK btw, replaced graphrbac with the official sdk only to discover build time went up an absurd amount.

@manicminer manicminer added the enhancement New feature or request label Sep 14, 2022
@manicminer
Copy link
Owner

@mathiaac Thanks for the compliment, and the suggestion. We'll definitely look into supporting this.

@mathiaac
Copy link
Author

@manicminer Thanks! Do you have a rough estimation of when that feature potentially will be in place?

@manicminer
Copy link
Owner

manicminer commented Sep 15, 2022

We're working on a pretty big refactor at the moment that will make this sort of change much easier, so I hesitate to give an estimate however it's not something I have time for right now. PRs always welcome in the meantime however, even if for an reference/interim implementation :)

@DaniJG
Copy link

DaniJG commented Jul 9, 2024

FYI, this would enable something I was considering downstream, which was for terraform's AD provider to allow listing all members of a group who are of a given type.

Without this, when getting the group members, we just get the list of object_ids and then one has to use azuread_directory_object for every one of those (sending an extra call to the graph API) to get its type and finally filter to the ones that you are interested.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants