Support more APIs, auth refactoring, multi-tenant auth, implement autorest.Authorizer, remove Azure Germany #123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manicminer
changed the title
manicminer
added
breaking change
manicminer
changed the title
manicminer
requested review from
jackofallops,
katbyte,
koikonom,
stephybun and
tombuildsstuff
manicminer
added a commit
to hashicorp/go-azure-helpers
that referenced
this pull request
Nov 10, 2021
manicminer
added a commit
to hashicorp/go-azure-helpers
that referenced
this pull request
Nov 10, 2021
- Remove auth.Api type - NewAuthorizer and family helper funcs now accept an environments.Api argument instead - Refactor msgraph tests to tidy up client instantiation and comodditize across all tests, improves test readability - auth.AzureCliAuthorizer now supports auxiliary tenants - Remove AzureCliName from environments.Api definitions, instead use the resource URI when calling az-cli - Add environment.Api definitions for additional supported APIs - Add additional definitions to environments.Environment definitions
manicminer
force-pushed
the
feature/more-apis
branch
from
74417cb
to
e696b64
Compare
manicminer
added a commit
to hashicorp/go-azure-helpers
that referenced
this pull request
Nov 10, 2021
manicminer
added a commit
to hashicorp/go-azure-helpers
that referenced
this pull request
Nov 10, 2021
tombuildsstuff
approved these changes
Nov 15, 2021
…est, clean up ctx handling for connection and clients
manicminer
force-pushed
the
feature/more-apis
branch
from
cf89a9d
to
8fc4f64
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Auth package refactoring:
auth.Apitype and instead useenvironments.ApidirectlyAdd the
AuxiliaryTokens()method to theauth.Authorizerinterface to support obtaining tokens for additional tenantsExpand support in
auth.AutorestAuthorizerWrapperto support anyautorest.Authorizerautorest.BearerAuthorizerandautorest.MultiTenantBearerAuthorizerare fully supported with access tokens, refresh tokens and expirySupport auxiliary tenants with client secret and client certificate authorizers
Implement the
autorest.Authorizerinterface withauth.CachedAuthorizer(which wraps all supported Authorizers)auth.MsiAuthorizerExport environment configs for more management plane APIs:
Refactor and tidy up tests for the
msgraphpackageSay goodbye to Azure Germany 🇩🇪
auth.NewClientCertificateAuthorizer,auth.NewClientSecretAuthorizerandauth.NewAzureCliAuthorizerhave changed to accommodate passing additional tenant IDs for multi-tenant authorization.