Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update endpoints KeyVaultUSGovEndpoint const #128

Merged
merged 1 commit into from
Nov 26, 2021
Merged

Update endpoints KeyVaultUSGovEndpoint const #128

merged 1 commit into from
Nov 26, 2021

Conversation

MarkDordoy
Copy link
Contributor

Fix type for us gov endpoint

@MarkDordoy
Update endpoints.go
948b9fe 
Fix type for us gov endpoint
@MarkDordoy MarkDordoy changed the title Update endpoints.go Update endpoints KeyVaultUSGovEndpoint const Nov 26, 2021
@MarkDordoy
Copy link
Contributor Author

@manicminer FYI

manicminer
manicminer approved these changes Nov 26, 2021
View reviewed changes
Copy link
Owner

@manicminer manicminer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix @MarkDordoy 👍

@manicminer manicminer added this to the v0.37.0 milestone Nov 26, 2021
@manicminer manicminer added bug Something isn't working package/environments labels Nov 26, 2021
@manicminer manicminer merged commit 213b47c into manicminer:main Nov 26, 2021
@MarkDordoy MarkDordoy deleted the patch-1 branch November 26, 2021 16:51
manicminer added a commit that referenced this pull request Nov 26, 2021
@manicminer
Changelog for #128
e742b9c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manicminer manicminer manicminer approved these changes

Assignees
No one assigned
Labels
bug Something isn't working package/environments
Projects
None yet
Milestone
v0.37.0
Development

Successfully merging this pull request may close these issues.
2 participants
@MarkDordoy @manicminer