-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EntitlementManagement - Add Types, move catalogs and packages to 1.0 Stable #133
Conversation
I also need to add "#microsoft.graph.question"to questions Struct, will do this later |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @kaovd, thanks for working on this! I've made a couple of notes on compatibility between the 1.0 and beta APIs if you can consider these? There may be other divergences I have missed. If it's impractical to maintain compatibility (e.g. perhaps the beta API isn't working right) then that's fine, but for now if we can that'd be good.
Seems the test for AppRoleAssignedToClient.Assign is having issues @manicminer - do you want to try fix within the PR or just do it in as seperate fix |
Have synced with main build now passing @manicminer |
…x/identitygovernance
…ilton into fix/identitygovernance
AccessPackageResourceRequests tests are now failing for some reason likely may have changed MS side need to review |
Can you give these tests a run locally @manicminer - I am not quite sure what the issues is with the CI but seem broken, they pass fine for me locally |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @kaovd, thanks for working on fixing this up, and sorry for the delay in reviewing. The test failure looks like a race condition stemming from the group creation - adding a sleep after line 21 in accesspackageresourcerequest_test.go seems to mitigate but we can leave that for now in lieu of a more robust way to handle propagation delays.
This LGTM! 🚀
Bugfixes and make stable where possible parts of the EntitlementManagement scopes
ODataTypes are required to be passed on the UserSet Struct