Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add app IDs for Front Door #175

Merged
merged 3 commits into from
Sep 29, 2022
Merged

add app IDs for Front Door #175

merged 3 commits into from
Sep 29, 2022

Conversation

t3mi
Copy link
Contributor

@t3mi t3mi commented Sep 5, 2022

Copy link
Owner

@manicminer manicminer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@t3mi Thanks for these additions. I'm happy to add these but have a small request about the formatting (below) if you can take a look? Thanks!

environments/published.go Outdated Show resolved Hide resolved
@manicminer manicminer added this to the v0.48.0 milestone Sep 29, 2022
Copy link
Owner

@manicminer manicminer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just need to fix the syntax errors

environments/published.go Outdated Show resolved Hide resolved
environments/published.go Outdated Show resolved Hide resolved
@manicminer manicminer merged commit cb40f53 into manicminer:main Sep 29, 2022
manicminer added a commit that referenced this pull request Sep 29, 2022
@t3mi
Copy link
Contributor Author

t3mi commented Sep 29, 2022

What a failure in two strings! @manicminer sorry for that..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants