Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Continuing Terms of Use #209

Merged
merged 4 commits into from
Feb 13, 2023
Merged

Continuing Terms of Use #209

merged 4 commits into from
Feb 13, 2023

Conversation

alexwilcox9
Copy link
Contributor

Picking up where #62 left off

I had a go at using the new file property but didn't have much luck. If both Files and File are empty the response is:
unexpected status 400 with OData error: BadRequest: Either policyFileLocalizations or policyFile has to be populated.
However trying to send only File results in:
unexpected status 400 with OData error: BadRequest: Value cannot be null. Parameter name: source

Googling this the only related article I could find was microsoftgraph/msgraph-sdk-powershell#652 and as far as I can see they are using Files which does work for us

Running tool: /home/linuxbrew/.linuxbrew/bin/go test -timeout 10m -run ^TestTermsOfUseAgreementClient$ github.com/manicminer/hamilton/msgraph

ok  	github.com/manicminer/hamilton/msgraph	5.094s

It's probably worth adding a client for creating agreements on existing ToU as shown here:
https://learn.microsoft.com/en-us/graph/api/agreement-post-files

Let me know what you think

Thanks

Copy link
Owner

@manicminer manicminer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this @alexwilcox9, appreciate your tracking this and figuring out the endpoint bugs. LGTM 👍

@manicminer manicminer added enhancement New feature or request package/msgraph labels Feb 13, 2023
@manicminer manicminer added this to the v0.56.0 milestone Feb 13, 2023
@manicminer manicminer merged commit b8b6688 into manicminer:main Feb 13, 2023
manicminer added a commit that referenced this pull request Feb 13, 2023
kenchan0130 pushed a commit to kenchan0130/hamilton that referenced this pull request Feb 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request package/msgraph
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants