Add support for pkcs12 bundles #212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Switch to using `software.sslmate.com/src/go-pkcs12`'s DecodeChain method in order to allow loading bunbles that contain a full cert chain.
manicminer
approved these changes
Feb 13, 2023
There was a problem hiding this comment.
Hi @kiall, thanks for this change. This looks reasonable to me, and handy that the DecodeChain function outputs the leaf certificate separately. LGTM 🚀
|
(Test failure unrelated and due to PR from fork) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switch to using
software.sslmate.com/src/go-pkcs12's DecodeChain method in order to allow loading bundles that contain a full cert chain.