Implement support for CAP guestsOrExternalUsers #262
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes came from gofumpt.
Need to explicitly send field with null value for the patch operation to affect it.
|
Work in progress PR where the changes are intended to be used: hashicorp/terraform-provider-azuread#1222 |
manicminer
approved these changes
Oct 25, 2023
There was a problem hiding this comment.
Many thanks for this @agileknight! Just a couple suggestions below, which I'll go ahead and add, this otherwise LGTM 🦖
agileknight
added a commit
to agileknight/hamilton
that referenced
this pull request
Oct 26, 2023
Without setting the correct @odata.type for both possible values all and enumerated, a patch will fail when first enumerating and setting members and then changing to type all because the stored object is of the wrong type. References manicminer#262
agileknight
added a commit
to agileknight/hamilton
that referenced
this pull request
Oct 26, 2023
Without setting the correct @odata.type for both possible values all and enumerated, a patch will fail when first enumerating and setting members and then changing to type all because the stored object is of the wrong type. References manicminer#262
|
@manicminer I created a follow-up PR after more thorough testing: #264 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #261