Owned objects API for service principal #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manicminer
reviewed
May 4, 2021
There was a problem hiding this comment.
Thanks for this PR @tsologub! This mostly LGTM, I'm just getting an intermittent test failure for which I've proposed a workaround. Let me know what you think and once we have a solid test this should be good to merge :)
tsologub
commented
May 4, 2021
manicminer
approved these changes
May 17, 2021
There was a problem hiding this comment.
Sorry for the delay in re-reviewing @tsologub, this looks great and passes for me. Thanks again!
|
@manicminer no problem. When are you planning to make a |
|
@tsologub Should be sometime in the next day or so |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for service principal "owned objects" API. Hidden, but quite handy functionality.