Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

List deleted API for apps, groups, and users #48

Merged
merged 5 commits into from
May 27, 2021
Merged

List deleted API for apps, groups, and users #48

merged 5 commits into from
May 27, 2021

Conversation

tsologub
Copy link
Contributor

Add support for listing deleted applications, groups, and users. (i.e. basically this page)

Notes to the reviewer:
As

unexpected status 400 with OData error: Request_BadRequest: The service does not currently support writes of mail-enabled groups. Please ensure that the mail-enablement property is unset and the security-enablement property is set.

is not yet supported at the moment and it is a long-desired feature - I left the "Groups part" without a test case. I have tested this manually by creating+deleting O365 group and afterward executing GroupsClient.ListDeleted().

@manicminer manicminer added the enhancement New feature or request label May 25, 2021
@manicminer manicminer self-requested a review May 25, 2021 14:02
@manicminer manicminer added this to the v0.14.0 milestone May 25, 2021
Copy link
Owner

@manicminer manicminer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @tsologub, thanks for this PR! This mostly LGTM - I've pushed a change to the ListDeleted methods so that they return slices of their respective struct type, and added a check to each of the tests to verify the recently deleted object is returned. I also added some missing fields for Applications and Users; there are still some short but these can be added later.

@tsologub
Copy link
Contributor Author

Thanks for reviewing @manicminer.

I've pushed a change to the ListDeleted methods so that they return slices of their respective struct type,

This totally makes sense. Now I wonder why I went with the slice of ids instead of the type. 🤔

and added a check to each of the tests to verify the recently deleted object is returned

Perfect. Even more robust tests.

@manicminer manicminer merged commit 72a97cf into manicminer:main May 27, 2021
@tsologub tsologub deleted the feature/list-deleted branch May 27, 2021 14:26
manicminer added a commit that referenced this pull request May 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants