Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add memberOf property to user struct #84

Merged
merged 2 commits into from
Aug 17, 2021
Merged

Add memberOf property to user struct #84

merged 2 commits into from
Aug 17, 2021

Conversation

LalitLab
Copy link
Contributor

Sample output of running func testUsersClient_List

 msgraph git:(main) ✗ go test -v -run TestUsersClient /Users/lalitbhardwaj/Turbot/prod/hamilton/msgraph 
=== RUN   TestUsersClient
2021/07/28 20:24:02 Abhinash
2021/07/28 20:24:02 
 ### GROUP NAMES ###
2021/07/28 20:24:02 Global Administrator aaaaaaaa-bbbb-cccc-dddd-f1f2f3f4f5f6
2021/07/28 20:24:02 User Administrator aaaaa866-cccc-4ee8-eeee-bf854b177920
2021/07/28 20:24:02 
2021/07/28 20:24:02 abhyudaya

@manicminer manicminer added this to the v0.24.0 milestone Jul 28, 2021
@manicminer manicminer added the enhancement New feature or request label Jul 28, 2021
LalitLab added a commit to LalitLab/hamilton that referenced this pull request Jul 29, 2021
@LalitLab
Add memberOf property to user struct. (manicminer#84)
54f6c66
@MarkDordoy
Copy link
Contributor

@LalitTurbot if you rebase off master you will pull in this fix here: d8d968b which should get your tests passing.

@LalitLab
Copy link
Contributor Author

LalitLab commented Aug 12, 2021 •
edited
Loading

@LalitTurbot if you rebase off master you will pull in this fix here: d8d968b which should get your tests passing.

Thank you
I have rebased my branch of the latest master

@manicminer
Copy link
Owner

@LalitTurbot Thanks for rebasing and sorry for the delay in reviewing. I've been working on support for generic directory objects and odata link fields. Once #86 is merged I'll have a look at merging this :)

manicminer
manicminer approved these changes Aug 17, 2021
View reviewed changes
Copy link
Owner

@manicminer manicminer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@LalitTurbot Thanks, this looks great. I rebased after merging #86 and this seems to work fine 👍

@manicminer manicminer merged commit ce0003f into manicminer:main Aug 17, 2021
manicminer added a commit that referenced this pull request Aug 17, 2021
@manicminer
Changelog for #84
bf4cf73
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manicminer manicminer manicminer approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
v0.24.0
Development

Successfully merging this pull request may close these issues.
3 participants
@LalitLab @MarkDordoy @manicminer