Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cache access tokens from Azure CLI #88

Merged
merged 2 commits into from
Aug 17, 2021
Merged

Cache access tokens from Azure CLI #88

merged 2 commits into from
Aug 17, 2021

Conversation

manicminer
Copy link
Owner

Avoid unnecessarily invoking az just to get a cached token

Fixes: #87

@manicminer manicminer added the bug Something isn't working label Aug 16, 2021
@manicminer manicminer added this to the v0.24.0 milestone Aug 16, 2021
@manicminer manicminer mentioned this pull request Aug 16, 2021
Closed
tombuildsstuff
tombuildsstuff approved these changes Aug 17, 2021
View reviewed changes
Copy link
Collaborator

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@manicminer manicminer merged commit 6216e0f into main Aug 17, 2021
@manicminer manicminer deleted the bugfix/cli-ulimit branch August 17, 2021 10:40
manicminer added a commit that referenced this pull request Aug 17, 2021
@manicminer
Changelog for #88
c56e468
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tombuildsstuff tombuildsstuff tombuildsstuff approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
v0.24.0
Development

Successfully merging this pull request may close these issues.

Error: ServicePrincipalsClient.BaseClient.Get(): launching Azure CLI: pipe: too many open files
2 participants
@manicminer @tombuildsstuff