Don't mutate pointer array. Performance speedup. #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@manuelstofer Please review it. |
|
Thanks! Looks good! |
manuelstofer
added a commit
that referenced
this pull request
Mar 18, 2016
Don't mutate pointer array. Performance speedup.
|
@manuelstofer Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this change every function modify the value of pointer array.
Didn't expect such behaviour so spend ~20 min figuring what happing.
As a nice bonus, it provides a significant speedup.
Since
shiftis ~10x slower thanfor(...), see:http://jsperf.com/array-reverse-pop-versus-shift/2