Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Self assignment #172

Merged
merged 8 commits into from
Sep 25, 2019
Merged

Self assignment #172

merged 8 commits into from
Sep 25, 2019

Commits on Aug 13, 2019

  1. add self-assignment checks in copy and move assignment operator= (ref #… 

    …164)
    @artemp
    artemp committed Aug 13, 2019
    Configuration menu
    Copy the full SHA
    4da4557 View commit details
    Browse the repository at this point in the history

  2. disable -Wself-assign-overloaded (-Werror) in self-assignment test

    @artemp
    artemp committed Aug 13, 2019
    Configuration menu
    Copy the full SHA
    ad85832 View commit details
    Browse the repository at this point in the history

  3. don't fail old compilers 

    ```
test/t/optional.cpp:94:34: error: unknown warning group

      '-Wself-assign-overloaded', ignored [-Werror,-Wunknown-pragmas]

```
    @artemp
    artemp committed Aug 13, 2019
    Configuration menu
    Copy the full SHA
    7918a48 View commit details
    Browse the repository at this point in the history

  4. Revert "don't fail old compilers" 

    This reverts commit 7918a48.
    @artemp
    artemp committed Aug 13, 2019
    Configuration menu
    Copy the full SHA
    da2b171 View commit details
    Browse the repository at this point in the history

  5. Revert "disable -Wself-assign-overloaded (-Werror) in self-assignment… 

    … test"

This reverts commit ad85832.
    @artemp
    artemp committed Aug 13, 2019
    Configuration menu
    Copy the full SHA
    94fc937 View commit details
    Browse the repository at this point in the history

Commits on Sep 25, 2019

  1. Improve self-assignment/move checks to have one return path.

    @artemp
    artemp committed Sep 25, 2019
    Configuration menu
    Copy the full SHA
    767bc18 View commit details
    Browse the repository at this point in the history

  2. Just use assert(this!=&other) in move assignment operator (https://… 

    …stackoverflow.com/questions/9322174/move-assignment-operator-and-if-this-rhs)
    @artemp
    artemp committed Sep 25, 2019
    Configuration menu
    Copy the full SHA
    b36c78e View commit details
    Browse the repository at this point in the history

  3. updated move assignment as suggested in #172 (comment)

    @artemp
    artemp committed Sep 25, 2019
    Configuration menu
    Copy the full SHA
    3dcac64 View commit details
    Browse the repository at this point in the history