Skip to content

Commit

Permalink
add progress plotting to correspondence copier and opensfm.reconstructor
Browse files Browse the repository at this point in the history 
Summary:
To make it easier to track reconstruction progress in larger jobs, this diff adds
- logging to the `opensfm.reconstructor` how many shots we already have in a map
- `tqdm` logging to the most expensive loops of the `copy_view_correspondences_between_pose_graph_and_component` module.

Differential Revision: D51964593

fbshipit-source-id: 08a4e81f6464329da01ba78e41d5142c7db0e848
  • Loading branch information
@facebook-github-bot
Michael Waechter authored and facebook-github-bot committed Dec 8, 2023
1 parent 925d7ff commit 6a1f95e
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions opensfm/reconstruction.py
View file
Original file line number Diff line number Diff line change
Expand Up @@ -1494,6 +1494,8 @@ def grow_reconstruction(
remove_outliers(reconstruction, config, bundled_points)
step["local_bundle"] = brep

logger.info(f"Reconstruction now has {len(reconstruction.shots)} shots.")

break
else:
logger.info("Some images can not be added")
Expand Down

1 comment on commit 6a1f95e

@kielnino
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see any additions in the code matching the claim

  • tqdm logging to the most expensive loops of the copy_view_correspondences_between_pose_graph_and_component module.

in the commit-message!? Did I miss something?

Please sign in to comment.