Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ingest DO, ORDO, OMIM, NCIT mappings #5

Open
3 tasks
matentzn opened this issue Feb 24, 2022 · 17 comments
Open
3 tasks

Ingest DO, ORDO, OMIM, NCIT mappings #5

matentzn opened this issue Feb 24, 2022 · 17 comments
Assignees

Comments

@matentzn
Copy link
Contributor

  • Have separate goals for obtaining the sources, which may eventually be extended to contain preprocessing (e.g. mirror/do.owl:)
  • Using sssom-py extract all mappings from DO, ORDO, OMIM and NCIT.
  • Manually review a dozen or so in the source ontology whether they don't contain extract curation information (ORDO ntbt for example)
@matentzn
Copy link
Contributor Author

@hrshdhgd
Copy link
Contributor

@matentzn
Copy link
Contributor Author

Yeah, maybe.. Not sure. I guess I am wondering whether ncit.owl contains the mappings mentioned on this page, and if the page is mentioning these two, then yes.

I would love these mappings, especially the newest one, to be included here!

@hrshdhgd
Copy link
Contributor

So ncit.owl has just the mention of ICD10 2017 in them. Does not seem to have the actual ICD10 code. Although the mapping tables linked above have the mapping: 800 (ICD10 2017), 15 (ICD10 2016) and have the corresponding NCIT code.

@matentzn
Copy link
Contributor Author

Perfect, thank you for checking. In this case, let's build an ingest into SSSOM for these!

@hrshdhgd
Copy link
Contributor

So do you mean having a new method in sssom-py that accommodates for external mapping files?

@matentzn
Copy link
Contributor Author

matentzn commented Feb 24, 2022

Bit unsure where to draw the line. Maybe for now a simple python script that imports SSSOM mapping and mapping sets and just do it externally? I told @joeflack4 to add the ICD10-snomed mapping parser to SSSOM py but I am not sure. Maybe yes, adding it to parsers would be an option. For now the answer is: python, in whatever way you like. But perhaps having a method from_ncit() in parsers.py would be awesome.

@hrshdhgd
Copy link
Contributor

Alright, for the time being I'll just do an external JOIN so to speak to include it in the SSSOM mappings as a quick-n-dirty solution. We can discuss a generic solution down the road after having experience with the different scenarios.

@matentzn
Copy link
Contributor Author

Sounds good!

@hrshdhgd
Copy link
Contributor

ICD mapping column:

RELATIONSHIP_TO_TARGET

Broader Than
Related To
Has Synonym
Narrower Than

Which one would be appropriate?

"Broader Than": "skos:broader",
"Related To": "skos:relatedMatch",
"Has Synonym": "skos:altLabel",
"Narrower Than": "skos:related",

or

"Broader Than": "oboInOwl:hasBroadSynonym",
"Related To": "oboInOwl:hasRelatedSynonym",
"Has Synonym": "oboInOwl:hasExactSynonym",
"Narrower Than": "oboInOwl:hasNarrowSynonym",

@matentzn
Copy link
Contributor Author

It's confusing but bare with me:

  • Broader than: skos:narrowMatch
  • Narrower than skos:broadMatch

@matentzn
Copy link
Contributor Author

Related to : skos:relatedMatch

We don't need synonym unless the object of synonym is a code and not a label. What about "equivalent"?

@matentzn
Copy link
Contributor Author

Maybe synonym is equivalent

@hrshdhgd
Copy link
Contributor

hrshdhgd commented Feb 24, 2022

  • skos:closeMatch,
  • skos:exactMatch,
  • owl:sameAs,
  • owl:equivalentClass,
  • owl:equivalentProperty

from https://www.w3.org/TR/skos-reference/#L4858

@matentzn
Copy link
Contributor Author

Use skos:exactMatch in these cases

hrshdhgd added a commit that referenced this issue Feb 25, 2022
@matentzn
Copy link
Contributor Author

matentzn commented Mar 3, 2022

Just for recording (no need to concern yourself): NCIT versions can be found here: https://stars.renci.org/var/NCIt/releases/)

@matentzn
Copy link
Contributor Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants