-
Notifications
You must be signed in to change notification settings - Fork 132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove provider specific functions from mxn.js #308
Comments
The presence of Where They could live in In the meantime, this is now part of the Release 3.0 milestone, so it doesn't get forgotten. |
Sorry, I wasn't clear. I didn't mean expose them publicly as part of the provider, I mean't that if they're being used in the Google provider code they should just be private functions in that code somewhere. |
In that case they can probably be obsoleted entirely. Neither Furthermore, if you look at the comments around line 427, both these function make an assumption about the relationship of zoom level to pixels to degrees. It's looking more and more like these can just be made to go away. |
mxn.js has some provider specific functions that should probably be either moved into the appropriate provider file or removed all together.
convertLatLonXY_Yahoo
getDegreesFromGoogleZoomLevel
getGoogleZoomLevelFromDegrees
The text was updated successfully, but these errors were encountered: