-
-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
clearState doesn't take care of pending threads #32
Comments
Yet another mitigation could be to sql_interrupt, prior to calling close_v2 from |
I took a bit more, but managed to fix the crash when reloading the bundle via react-native-restart. You can give it a try with Codepush and let me know if it works. For now, I will stop spamming margelo since quick-sqlite belongs to them now. |
Hi Franco, many thanks for addressing this issue! That's a very thorough fix. Just one suggestion. This comment is no longer accurate in my opinion:
It could be replace with sth like: |
I've noticed that the sqlite lib crashes when codepush restarts the app, if there are a pending async queries.
The reason is that it tries to use a runtime that doesn't exist anymore, crashing here.
I had previously tried to mitigate this issue with #16. While correct, it still allows pending executions to complete, causing these crashes.
One way to fix this is to kill ThreadPool's threads from
osp::clearState()
.@ospfranco any thoughts?
Full stack trace
The text was updated successfully, but these errors were encountered: