Skip to content
This repository has been archived by the owner on Oct 5, 2020. It is now read-only.

Enabling blue design breaks gulp serve-prod #221

Closed
grtjn opened this issue Sep 23, 2015 · 4 comments
Closed

Enabling blue design breaks gulp serve-prod #221

grtjn opened this issue Sep 23, 2015 · 4 comments
Labels
Milestone

Comments

@grtjn
Copy link
Contributor

grtjn commented Sep 23, 2015

[00:28:56] Plumber found unhandled error:
 Error in plugin 'gulp-minify-css'
Message:
    Broken @import declaration of "https://fonts.googleapis.com/css?family=Lato:300,400,700" - timeout
Details:
    fileName: /space/projects/github-search.live/ui/styles/app.css
[00:28:56] Plumber found unhandled error:
 Error: no writecb in Transform class

Simplest way out is to just disable that line in ui/styles/blues.less..

@grtjn grtjn added the bug label Sep 23, 2015
@grtjn grtjn added this to the 0.2.0 milestone Sep 23, 2015
@jenbreese
Copy link
Contributor

@grtjn It is very ugly without that font. Why wouldn't it break on gulp serve-local or gulp serve-dev but it does on prod? If the best solution is to remove the font, then i need to find another font because it is too ugly to live without the Lato. What is your recommendation?

@hunterwilliams
Copy link
Contributor

Think I may know a fix for this. Turns out it's the error I was hoping to see. Unfortunately, can't recall the page I found for this back when there was related issue. It is solvable though!

@hunterwilliams
Copy link
Contributor

Got it. https:/jakubpawlowicz/clean-css which gulp-minify-css wraps provides processImportFrom which allows blacklisting imports, which was added in support of this very issue: clean-css/clean-css#632

Also for reference, this bug affects any build that trigged the optimize task

grtjn added a commit that referenced this issue Sep 24, 2015
#221 Ignore google fonts import during minification
@grtjn
Copy link
Contributor Author

grtjn commented Sep 24, 2015

Yeah, to summarize, gulp serve-dev/prod makes the css go through a minify for optimization, and that choked on the google fonts link. By skipping that the issue was solved..

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

3 participants