Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JNetReflector uses Java.Lang.String instead of string (System.String) #364

Conversation

masesdevelopers
Copy link
Contributor

Description

JNetReflector, by default, uses Java.Lang.String instead of string (System.String)

NOTE: This is a breaking change

Related Issue

closed #363

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@masesdevelopers masesdevelopers added enhancement New feature or request JNet JNet related issue JNetPS JNetPS releated issue .NET Pull requests that update .net code labels Feb 13, 2024
@masesdevelopers masesdevelopers self-assigned this Feb 13, 2024
@masesdevelopers masesdevelopers merged commit bacf50e into masesgroup:master Feb 19, 2024
7 checks passed
@masesdevelopers masesdevelopers deleted the 363-avoid-use-of-string-systemstring-and-prefer-javalangstring branch February 19, 2024 23:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request JNet JNet related issue JNetPS JNetPS releated issue .NET Pull requests that update .net code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Avoid use of string (System.String) and prefer Java.Lang.String
1 participant