Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add side-menu #108

Merged
merged 1 commit into from
May 25, 2023
Merged

add side-menu #108

merged 1 commit into from
May 25, 2023

Conversation

mazmassa
Copy link
Contributor

@mazmassa mazmassa commented May 24, 2023 •
edited
Loading

We are adding a <SideMenu> component.

Screenshot 2023-05-24 at 17 46 26

⚠️ We must fix SVG + JEST to be able to test.

maxime-carabina
maxime-carabina approved these changes May 24, 2023
View reviewed changes
Copy link
Contributor

@maxime-carabina maxime-carabina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove comments in test file. But LGTM 🎉

src/components/SideMenu/SideMenu.test.tsx Outdated Show resolved Hide resolved
@mazmassa mazmassa merged commit 8aceb79 into main May 25, 2023
@mazmassa mazmassa deleted the add-side-menu branch May 25, 2023 07:59
@Thykof Thykof mentioned this pull request May 26, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxime-carabina maxime-carabina maxime-carabina approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mazmassa @maxime-carabina