Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add description component #172

Merged
merged 1 commit into from
Jun 6, 2023
Merged

add description component #172

merged 1 commit into from
Jun 6, 2023

Conversation

lilyanB
Copy link
Contributor

@lilyanB lilyanB commented Jun 6, 2023

image

@lilyanB lilyanB linked an issue Jun 6, 2023 that may be closed by this pull request
add description component #169
Closed
mazmassa
mazmassa reviewed Jun 6, 2023
View reviewed changes
src/components/Description/Description.stories.tsx Outdated Show resolved Hide resolved
src/components/Description/Description.stories.tsx Outdated Show resolved Hide resolved
src/components/Description/Description.tsx Outdated Show resolved Hide resolved
src/components/Description/Description.tsx Outdated Show resolved Hide resolved
@lilyanB lilyanB force-pushed the 169-add-description-component branch 7 times, most recently from e20faf2 to 7938406 Compare June 6, 2023 13:21
mazmassa
mazmassa approved these changes Jun 6, 2023
View reviewed changes
Copy link
Contributor

@mazmassa mazmassa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for that Lylian! 👏

Double check the colour (dark/light) and check the logo that is deformed in the small version.

Approving here meanwhile. Feel free to merge when this is fixed and you have a second approve.

@lilyanB lilyanB force-pushed the 169-add-description-component branch from 7938406 to 7d7ff52 Compare June 6, 2023 13:35
@lilyanB lilyanB force-pushed the 169-add-description-component branch from 7d7ff52 to f488765 Compare June 6, 2023 14:45
@lilyanB lilyanB force-pushed the 169-add-description-component branch from f488765 to bc54988 Compare June 6, 2023 15:24
@lilyanB lilyanB force-pushed the 169-add-description-component branch from bc54988 to 3d49c36 Compare June 6, 2023 15:25
@lilyanB lilyanB merged commit 127c426 into main Jun 6, 2023
@lilyanB lilyanB deleted the 169-add-description-component branch June 6, 2023 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mazmassa mazmassa mazmassa approved these changes

@maxime-carabina maxime-carabina maxime-carabina approved these changes

Assignees

@lilyanB lilyanB

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

add description component
3 participants
@lilyanB @maxime-carabina @mazmassa