Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add password component #33

Merged
merged 1 commit into from
May 3, 2023
Merged

add password component #33

merged 1 commit into from
May 3, 2023

Conversation

mazmassa
Copy link
Contributor

@mazmassa mazmassa commented May 2, 2023

We are adding a <Password /> component.

Screenshot 2023-05-02 at 16 48 44

Design Spec

@mazmassa mazmassa force-pushed the add-password-component branch 3 times, most recently from 2f1f11f to 2eb8734 Compare May 2, 2023 17:44
pivilartisant
pivilartisant approved these changes May 3, 2023
View reviewed changes
Copy link
Contributor

@pivilartisant pivilartisant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments, but they are more about good practices so none blocking ! So LGTM :)

src/components/Password/Password.tsx Show resolved Hide resolved
@mazmassa mazmassa merged commit 134217e into main May 3, 2023
@mazmassa mazmassa deleted the add-password-component branch May 3, 2023 12:20
pivilartisant pushed a commit that referenced this pull request May 5, 2023
@mazmassa
add password component (#33)
4e2f26b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pierregvx Pierregvx Pierregvx approved these changes

@pivilartisant pivilartisant pivilartisant approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mazmassa @Pierregvx @pivilartisant