Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add stepper component #69

Merged
merged 1 commit into from
May 12, 2023
Merged

add stepper component #69

merged 1 commit into from
May 12, 2023

Conversation

mazmassa
Copy link
Contributor

@mazmassa mazmassa commented May 11, 2023 •
edited
Loading

We are adding the <Stepper> component.

Screenshot 2023-05-11 at 15 56 38

⚠️ We are not following the exact design for that, for now.

@mazmassa mazmassa force-pushed the add-stepper branch 3 times, most recently from f285c42 to efb7566 Compare May 11, 2023 14:15
pivilartisant
pivilartisant reviewed May 11, 2023
View reviewed changes
Copy link
Contributor

@pivilartisant pivilartisant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey mario I have two questions :

  • Is it possible to set the steps text under the icon like in design ?
  • Right now on storybook it's static but I see that you have written functions, will the step progression be implemented next ?

@mazmassa
Copy link
Contributor Author

mazmassa commented May 11, 2023 •
edited
Loading

Hey mario I have two questions :

  • Is it possible to set the steps text under the icon like in design ?
  • Right now on storybook it's static but I see that you have written functions, will the step progression be implemented next ?

My bad to no mention in the description! So,

  • Is it possible to set the steps text under the icon like in design ?

No, this will be a second version because it demands more time to finish. I have a previous version already done. But in future we update that.

Right now on storybook it's static but I see that you have written functions, will the step progression be implemented next

Sure! That's the plan!

maxime-carabina
maxime-carabina approved these changes May 11, 2023
View reviewed changes
Copy link
Contributor

@maxime-carabina maxime-carabina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mazmassa mazmassa merged commit b468941 into main May 12, 2023
@mazmassa mazmassa deleted the add-stepper branch May 12, 2023 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxime-carabina maxime-carabina maxime-carabina approved these changes

@pivilartisant pivilartisant pivilartisant approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mazmassa @maxime-carabina @pivilartisant