add vpc access connector to subnet #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WillBeebe
commented
Oct 6, 2022
| # This breaks if someone makes two subnet packages in the same region, in the same VPC. | ||
| # That's pretty unlikely but this should be replaced with md-terraform-utils eventually. | ||
| locals { | ||
| ranges = { |
There was a problem hiding this comment.
I think this is a better user experience than having to specify the /28 range. I can file an issue on this bundle for the bug: A user can't make two subnets in the same VPC in the same region.
mclacore
approved these changes
Oct 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The artifact change has been made and released. This makes the resource.