Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core.TxPool.truncateQueue() chucks out newer rather than older transactions when queue is too long #1016

Closed
svenski123 opened this issue Sep 24, 2023 · 2 comments
Closed

core.TxPool.truncateQueue() chucks out newer rather than older transactions when queue is too long #1016

svenski123 opened this issue Sep 24, 2023 · 2 comments

Comments

@svenski123
Copy link
Contributor

The eviction ordering in truncateQueue() is reversed so that newer transactions are erroneously discarded instead of older transactions when the global queue limit is exceeded.

This bug was corrected in upstream geth last year - it would be worthwhile merging or cherry picking into bor.

ethereum/go-ethereum#24907
ethereum/go-ethereum#24908

commit 2bfd9a28d11714c7880243ea28169d5f3e8fff11
Author: zhaochonghe <[email protected]>
Date:   Thu May 19 15:25:22 2022 +0800

    core: fix the order of address in queue (#24907)

    reverse the order of address in queue
@ssandeep
Copy link
Contributor

ssandeep commented Oct 3, 2023

@svenski123 , I think this has already been fixed in https:/maticnetwork/bor/blob/v1.0.4/core/txpool/txpool.go#L2192

@manav2401
Copy link
Contributor

Seems answered, closing for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ssandeep @svenski123 @manav2401