Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Highlight regex groups #127

Open
fawkstrot opened this issue Oct 5, 2024 · 1 comment
Open

Highlight regex groups #127

fawkstrot opened this issue Oct 5, 2024 · 1 comment

Comments

@fawkstrot
Copy link

First off, just want to say I love this client. This runs so smooth, and I just have to say thank you for your work here.

That said, running into a weird issue with highlighting regex groups not respecting the colors. I can get it to highlight the group properly, but it's not respecting my color settings and defaulting to some purple. I can get mixed results depending on tweaking the regex, but it's not working as expected.

I'l have "kertig (cowbell)" as the highlight text with the highlight regex groups option ticked. I've set the color to red. HJowever, it always uses some default color regardless of the option I set.

@matoom
Copy link
Owner

matoom commented Oct 9, 2024

Yep, this was definitely a bug, that only manifested in group highlights and went unnoticed for a couple of years it seems. There was a conflict in variable assignments and whatever color came first in the list of all the entries was wrongly used.

I pushed a new release that should fix this error (currently win binaries only):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants