Remove knocking build flag and Synapse's experimental config option #331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The flag no longer exists since Synapse v1.54.0.
anoadragon453
added a commit
to matrix-org/synapse
that referenced
this pull request
Mar 4, 2022
This flag will no longer be required after matrix-org/complement#331 is merged.
|
Please add failing Dendrite tests to the blacklist. |
anoadragon453
commented
Mar 10, 2022
|
I believe this is just waiting for an approval on your side @kegsay? |
|
Oh okay, I was waiting for someone on Synapse side to approve. |
|
Oh -- let's request review from them then. |
clokep
approved these changes
Mar 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As knocking has been stable for a while now (and is even in a released version of the spec), it is now certainly overdue to remove the build flag guarding Complement's knocking tests.
cc @matrix-org/dendrite-core
Recommended to review commit-by-commit.