[pseudoIDs] Allow displayname changes, kick users on redaction #3131
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes a few things to allow displayname/avatar changes in pseudo ID rooms.
GetRoomsByMembership
now queries the pseudo ID keys to get all roomsmxid_mapping
incontent
, the user leaves the room or is kickedcurrent_room_state
(if needed)join
->join
) we now remove themxid_mapping
fromunsigned.prev_content
)join
->join
event and temporarily add a prev_content, so validating the event signature doesn't error because of a missingmxid_mapping
A few things we need to think about:
Considering that users can leave rooms on their own and rejoin them, we now have two join events with a
mxid_mapping
. Currently redacting the current join event results in a leave/kick, but we still have another unredactedmxid_mapping
. It's up to the client to walk theunsigned.replaces_state
field to redact other membership events containing amxid_mapping
Kicking users, on redaction of a join event, may not always be possible, as the powerlevels could have been changed to allow redactions for PL50, but kicking is only allowed for PL100. How do we handle those cases? Temporarily fake/update the powerlevels to allow kicking?